Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): continue unit tests on error #5995

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

noahdietz
Copy link
Contributor

This will allow other language runtime versions in the testing matrix to continue even if one of them fails.

@noahdietz noahdietz requested review from a team as code owners March 23, 2023 17:17
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2023
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this marks tests as passing even if they've failed, which would defeat their purpose!

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the docs, this is only the case if continue-on-error is on a step in the job. If that step fails, the job will still succeed.

configuring continue-on-error at the job level will still allow the job to fail, but the other jobs in the same matric will continue.

@bshaffer bshaffer merged commit a7a27cb into googleapis:main Mar 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants