Upgrading from gcloud to google-cloud-bigtable. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Sep 29, 2016
| ] | ||
|
|
||
| SETUP_BASE.pop('url') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
In the process, also renaming all instances of gcloud.
In order to get passing system tests, Client.start() and Client.stop() had to stop being used. Also add a newline (per feedback) in setup.py.
dhermes
force-pushed
the
upgrade-deps
branch
from
f5ee1a8
to
7369de1
Compare
|
New changes in 7369de1 also LGTM |
|
Changes Unknown when pulling 7369de1 on dhermes:upgrade-deps into * on GoogleCloudPlatform:master*. |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process, also renaming all instances of gcloud.
NOTE: Has #10 as diffbase.