Bringing system test scripts up to date. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process, also renaming all instances of gcloud.
In order to get passing system tests, Client.start() and Client.stop() had to stop being used. Also add a newline (per feedback) in setup.py.
Also removing run_emulator since it isn't used anymore.
dhermes
force-pushed
the
upgrade-system-tests
branch
from
ed643fa
to
6a67531
Compare
theacodes
approved these changes
Sep 29, 2016
|
Changes Unknown when pulling 6a67531 on dhermes:upgrade-system-tests into * on GoogleCloudPlatform:master*. |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing run_emulator since it isn't used anymore.
NOTE: Has #12 as diffbase.