Skip to content

Commit

Permalink
test: fix vpcsc tests (#54)
Browse files Browse the repository at this point in the history
  • Loading branch information
busunkim96 committed Aug 27, 2020
1 parent a7c982c commit 90879c5
Showing 1 changed file with 21 additions and 17 deletions.
38 changes: 21 additions & 17 deletions packages/google-cloud-translate/tests/system/test_vpcsc.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ def glossary_outside(glossary_name_outside):

@vpcsc_config.skip_unless_inside_vpcsc
def test_create_glossary_w_inside(client, parent_inside, glossary_inside):
client.create_glossary(parent_inside, glossary_inside)
client.create_glossary(parent=parent_inside, glossary=glossary_inside)


@vpcsc_config.skip_unless_inside_vpcsc
def test_create_glossary_w_outside(client, parent_outside, glossary_outside):
with pytest.raises(exceptions.PermissionDenied) as exc:
client.create_glossary(parent_outside, glossary_outside)
client.create_glossary(parent=parent_outside, glossary=glossary_outside)

assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)

Expand All @@ -94,39 +94,39 @@ def test_list_glossaries_w_inside(client, parent_inside):
@vpcsc_config.skip_unless_inside_vpcsc
def test_list_glossaries_w_outside(client, parent_outside):
with pytest.raises(exceptions.PermissionDenied) as exc:
list(client.list_glossaries(parent_outside))
list(client.list_glossaries(parent=parent_outside))

assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)


@vpcsc_config.skip_unless_inside_vpcsc
def test_get_glossary_w_inside(client, glossary_name_inside):
try:
client.get_glossary(glossary_name_inside)
client.get_glossary(name=glossary_name_inside)
except exceptions.NotFound: # no perms issue
pass


@vpcsc_config.skip_unless_inside_vpcsc
def test_get_glossary_w_outside(client, glossary_name_outside):
with pytest.raises(exceptions.PermissionDenied) as exc:
client.get_glossary(glossary_name_outside)
client.get_glossary(name=glossary_name_outside)

assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)


@vpcsc_config.skip_unless_inside_vpcsc
def test_delete_glossary_w_inside(client, glossary_name_inside):
try:
client.delete_glossary(glossary_name_inside)
client.delete_glossary(name=glossary_name_inside)
except exceptions.NotFound: # no perms issue
pass


@vpcsc_config.skip_unless_inside_vpcsc
def test_delete_glossary_w_outside(client, glossary_name_outside):
with pytest.raises(exceptions.PermissionDenied) as exc:
client.delete_glossary(glossary_name_outside)
client.delete_glossary(name=glossary_name_outside)

assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)

Expand All @@ -140,11 +140,13 @@ def test_batch_translate_text_w_inside(client, parent_inside):
"gcs_destination": {"output_uri_prefix": "gs://fake-bucket/output/"}
}
client.batch_translate_text( # no perms issue
parent_inside,
source_language_code,
target_language_codes,
input_configs,
output_config,
request={
"parent": parent_inside,
"source_language_code": source_language_code,
"target_language_codes": target_language_codes,
"input_configs": input_configs,
"output_config": output_config,
}
)


Expand All @@ -158,11 +160,13 @@ def test_batch_translate_text_w_outside(client, parent_outside):
}
with pytest.raises(exceptions.PermissionDenied) as exc:
client.batch_translate_text(
parent_outside,
source_language_code,
target_language_codes,
input_configs,
output_config,
request={
"parent": parent_inside,
"source_language_code": source_language_code,
"target_language_codes": target_language_codes,
"input_configs": input_configs,
"output_config": output_config,
}
)

assert exc.value.message.startswith(_VPCSC_PROHIBITED_MESSAGE)

0 comments on commit 90879c5

Please sign in to comment.