Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to oauth2client 2.0. #1479

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Upgrading to oauth2client 2.0. #1479

merged 1 commit into from
Feb 17, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 17, 2016

Fixes #1477.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2016
@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
tseaver
tseaver reviewed Feb 17, 2016
View reviewed changes
setup.py
@@ -14,7 +14,7 @@
REQUIREMENTS = [
'httplib2 >= 0.9.1',
'googleapis-common-protos',
'oauth2client >= 1.4.6',
'oauth2client >= 2.0.0',

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author

dhermes commented Feb 17, 2016

Yeah I plan on upgrading in a subsequent PR

tseaver
tseaver reviewed Feb 17, 2016
View reviewed changes
gcloud/credentials.py
if credentials._private_key_pkcs12 is not None:
# Take our PKCS12 (.p12) text and convert to PEM text.
pem_text = crypt.pkcs12_key_as_pem(
credentials._private_key_pkcs12,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Feb 17, 2016
Closed
@tseaver
Copy link
Contributor

tseaver commented Feb 17, 2016

LGTM

dhermes added a commit that referenced this pull request Feb 17, 2016
@dhermes
Merge pull request #1479 from dhermes/oauth2client-2.0
09c3c98 
Upgrading to oauth2client 2.0.
@dhermes dhermes merged commit 09c3c98 into googleapis:master Feb 17, 2016
@dhermes dhermes deleted the oauth2client-2.0 branch February 17, 2016 15:33
This was referenced Feb 17, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: core cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhermes @tseaver @googlebot