Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden 'Message.from_api_repr' against missing 'data' #1481

Merged
merged 2 commits into from
Feb 17, 2016
Merged

Harden 'Message.from_api_repr' against missing 'data' #1481

merged 2 commits into from
Feb 17, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 17, 2016

e2b3ef7 also cleans up the order of testcase methods to match the actual order of Message methods.

Closes #1480

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Feb 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2016
@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2016

@tseaver Can you rebase since #1479 is in now?

@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2016

LGTM pending rebase / Travis

tseaver added a commit that referenced this pull request Feb 17, 2016
@tseaver
Merge pull request #1481 from tseaver/1480-pubsub-empty_payload-missi…
87c7a4c 
…ng_data

Harden 'Message.from_api_repr' against missing 'data'
@tseaver tseaver merged commit 87c7a4c into googleapis:master Feb 17, 2016
@tseaver tseaver deleted the 1480-pubsub-empty_payload-missing_data branch February 17, 2016 16:50
@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @dhermes @googlebot