ResourceManager: fix list_projects(filter_params) #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
zehauser
force-pushed
the
master
branch
2 times, most recently
from
32672a4
to
bfc1530
Compare
The filter_params parameter of resource_manager.Client.list_projects is a dict (of properties to filter on and the desired value for each property). Prior to this commit, this dict was passed into the HTTPIterator constructor in extra_params['filter']. This didn't work, because extra_params values can't be dicts. They *can* be iterables, but since the iterable of a dict is its keys, this resulted in only the properties being sent along in the 'filter' query param, while the desired values for those properties were discarded. This commit transforms the filter_params dict into a simple list prior to shoving it in extra_params, which fixes the bug.
theacodes
approved these changes
May 24, 2018
|
Thanks for doing this, @zehauser! |
|
@crwilcox can you cut a new release? |
|
⭐️🍰🎆! |
|
@crwilcox @theacodes bump to get this released when possible! :) |
tseaver
added
the
api: cloudresourcemanager
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
The filter_params parameter of resource_manager.Client.list_projects is a dict (of properties to filter on and the desired value for each property). Prior to this commit, this dict was passed into the HTTPIterator constructor in extra_params['filter']. This didn't work, because extra_params values can't be dicts. They *can* be iterables, but since the iterable of a dict is its keys, this resulted in only the properties being sent along in the 'filter' query param, while the desired values for those properties were discarded. This commit transforms the filter_params dict into a simple list prior to shoving it in extra_params, which fixes the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter_params parameter of resource_manager.Client.list_projects is
a dict (of properties to filter on and the desired value for each property).
Prior to this commit, this dict was passed into the HTTPIterator constructor
in extra_params['filter'].
This didn't work, because extra_params values can't be dicts. They can be
iterables, but since the iterable of a dict is its keys, this resulted in only
the properties being sent along in the 'filter' query param, while the desired
values for those properties were discarded.
This commit transforms the filter_params dict into a simple list prior to
shoving it in extra_params, which fixes the bug.