Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: allow setting None as partition expiration #6823

Merged
merged 1 commit into from
Dec 3, 2018
Merged

BigQuery: allow setting None as partition expiration #6823

merged 1 commit into from
Dec 3, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 1, 2018

Per internal bug report 120204617.

@tswast tswast requested a review from shollyman December 1, 2018 00:37
@tswast tswast requested a review from crwilcox as a code owner December 1, 2018 00:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2018
@tswast tswast added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 1, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2018
@tseaver tseaver changed the title Fix bug preventing explicitly setting None as partition expiration BigQuery: allow setting None as partition expiration Dec 3, 2018
@tseaver tseaver merged commit e9ddb89 into googleapis:master Dec 3, 2018
@tswast tswast deleted the b120204617-expiration branch December 3, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox crwilcox approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tswast @tseaver @crwilcox @shollyman @googlebot