Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub: Initialize 'StreamingPullFuture._cancelled' as True #6901

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Pubsub: Initialize 'StreamingPullFuture._cancelled' as True #6901

merged 4 commits into from
Dec 12, 2018

Commits on Dec 11, 2018

  1. [bug]StreamingPullFuture init with _cancelled = True

    @brunoais
    brunoais committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    5d8e366 View commit details
    Browse the repository at this point in the history

  2. add tests to confirm future starts with cancelled as false

    @brunoais
    brunoais committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    d967051 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Remove ill-directed assertions. 

    I wrongly asked that they be added in this file, rather than in `pubsub/tests/unit/pubsub_v1/subscriber/test_futures_subscriber.py`
    @tseaver
    tseaver committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    0501c10 View commit details
    Browse the repository at this point in the history

  2. Add assertion in the correct spot.

    @tseaver
    tseaver committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    b32976a View commit details
    Browse the repository at this point in the history