Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub/Sub ThreadScheduler should inherit from the base Scheduler ABC #7690

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 10, 2019

This PR makes the ThreadScheduler to subclass the base Scheduler (and not object).

How to test

Carefully gaze at the scheduler.ThreadScheduler class definition for about 3.14 seconds and await the Enlightenment. 😉

I see no apparent reason, why ThreadScheduler subclasses object directly, instead of the ABC defined in the very same file, as the interfaces of these two classes match.

@plamut plamut requested a review from crwilcox as a code owner April 10, 2019 17:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2019
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Apr 16, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 17, 2019
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@plamut
Copy link
Contributor Author

plamut commented Apr 24, 2019

@tseaver What does the rotating light label warn about? Is this PR safe to merge?

@sduskis
Copy link
Contributor

sduskis commented Apr 24, 2019

@plamut, the rotating light indicates that this PR is old and should get additional attention from reviewers. Please feel free to merge.

@plamut
Copy link
Contributor Author

plamut commented Apr 24, 2019

@sduskis Thank you, will happily do it.

@plamut plamut merged commit 7755867 into googleapis:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants