Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: fix instance leaks from snippets #7800

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Bigtable: fix instance leaks from snippets #7800

merged 3 commits into from
Apr 30, 2019

Conversation

sangramql
Copy link
Contributor

Fix issue
#7003

@sangramql sangramql requested a review from tseaver as a code owner April 24, 2019 21:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@sangramql
Copy link
Contributor Author

@crwilcox @AVaksman @sduskis
Please review the code.

tseaver
tseaver suggested changes Apr 29, 2019
View reviewed changes
bigtable/docs/snippets.py Outdated Show resolved Hide resolved
bigtable/docs/snippets.py Outdated Show resolved Hide resolved
bigtable/docs/snippets.py Show resolved Hide resolved
bigtable/docs/snippets.py Outdated Show resolved Hide resolved
bigtable/docs/snippets.py Outdated Show resolved Hide resolved
bigtable/docs/snippets.py Outdated Show resolved Hide resolved
@tseaver tseaver added api: bigtable Issues related to the Bigtable API. testing kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
@tseaver tseaver changed the title Fix instances leak from snippets Bigtable: fix instance leaks from snippets Apr 29, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
tseaver
tseaver suggested changes Apr 29, 2019
View reviewed changes
bigtable/docs/snippets.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2019
@tseaver tseaver merged commit 86f81d1 into googleapis:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sangramql @tseaver @googlebot @yoshi-kokoro