Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: systests leaking instances #7003

Closed
tseaver opened this issue Dec 19, 2018 · 3 comments · Fixed by #8416
Closed

Bigtable: systests leaking instances #7003

tseaver opened this issue Dec 19, 2018 · 3 comments · Fixed by #8416
Assignees
Labels
api: bigtable Issues related to the Bigtable API. flaky testing type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Dec 19, 2018

Similar to #4935. We have a bunch of leaked instances, and are now seeing systest failures due to quota exhaustion. With the labels, it is possible to see that several different "kinds" of instances are leaked from systests:

  • dif-#### (leaked from test_create_instance_w_two_clusters).
  • g-c-p-### w/ display name "Foo Bar Baz" (the default instance in tests/system.py, mutated by test_update_display_name_and_labels and not restored)
  • g-c-p-### w/o display name (the default instance in tests/system.py)
  • new-### (leaked from test_create_instance systest)

and from snippets:

  • inst-my-### (leaked one of two snippets: test_bigtable_create_instance or test_bigtable_delete_instance)
  • snippet-### w/ display name "My new instance" (default instance for snippets; display name set by 'test_bigtable_update_instance`)
  • snippet-### w/o display name (default instance for snippets)

I will delete have deleted all but the most recent example of each kind.

@tseaver tseaver added testing api: bigtable Issues related to the Bigtable API. type: process A process-related concern. May include testing, release, or the like. labels Dec 19, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Dec 19, 2018

@sduskis Can you have the team which has been working on snippets, etc. investigate those leaks?

@tseaver
Copy link
Contributor Author

tseaver commented Dec 19, 2018

#7004 has fixes in for all my hypotheses for instance leaks in tests/system.py. I have deleted the corresponding instances, so the only "old" ones remaining were leaked from docs/snippets.py.

tseaver added a commit that referenced this issue Dec 19, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Feb 7, 2019

I just cleaned out four instances leaked from snippets on 2018-12-18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. flaky testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant