Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: plug systest / snippet instance leaks. #8416

Merged
merged 6 commits into from
Jun 20, 2019
Merged

Bigtable: plug systest / snippet instance leaks. #8416

merged 6 commits into from
Jun 20, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 18, 2019

@busunkim96, @sduskis I think this would be easier to review commit-by-commit.

Closes #8378.
Closes #7003.

Makes debugging a group of leaked instances simpler.
- Add retries for 429 responses to all 'delete' requests.

- Share a single unique suffix across all snippets, to aid in diagnosing
  failures of multiple cleanups in a single job.

- Move most cleanups inside the creating snippet function:  leaving them
  around (particularly instances) to process end can block other jobs
  from running.

- Perform cleanups for tables, clusters, and app profiles.
@tseaver tseaver added testing api: bigtable Issues related to the Bigtable API. labels Jun 18, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2019

This is a testing-only change, and one which should prevent PRs for other APIs from failing CI due to quota exhaustion.

@tseaver tseaver merged commit e081c57 into googleapis:master Jun 20, 2019
@tseaver tseaver deleted the 8378-bigtable-plug-systest-snippet-instance-leaks branch June 20, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigtable: system tests failing with 'quota_exceeded' Bigtable: systests leaking instances
2 participants