Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing document is out of date #8707

Merged
merged 3 commits into from
Aug 1, 2019

Conversation

Kami
Copy link
Contributor

@Kami Kami commented Jul 18, 2019

Contributing document is out of date and references system_tests/data/index.yaml file with index definitions which doesn't exist (see #8636 (comment) for context / details).

In addition to that, it uses old and deprecated command for creating an index which is not available anymore in recent versions of gcloud CLI.

@Kami Kami requested a review from busunkim96 as a code owner July 18, 2019 15:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2019
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@tseaver tseaver added type: docs Improvement to the documentation for an API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@tseaver tseaver merged commit 4ed725f into googleapis:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants