Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Expose id field for HMAC key #9115

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Aug 27, 2019

This is exposed in the client libraries for other languages and
is required for the samples to match.

This is exposed in the client libraries for other languages and
is required for the samples to match.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@tritone tritone changed the title Expose id field for HMAC key Storage: Expose id field for HMAC key Aug 27, 2019
@tritone
Copy link
Contributor Author

tritone commented Aug 27, 2019

This addresses issue #9114 .

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@tseaver
Copy link
Contributor

tseaver commented Aug 27, 2019

@tritone Unit tests were broken by yesterday's release of google-resumable-media-python. Can you please rebase your branch against the current master?

@tritone
Copy link
Contributor Author

tritone commented Aug 28, 2019

@tseaver looks like that did the trick; thanks!

@tseaver tseaver merged commit 68fbc07 into googleapis:master Aug 28, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants