Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(recommender): generate v1beta1 #9257

Merged
merged 14 commits into from
Sep 27, 2019
Merged

feat(recommender): generate v1beta1 #9257

merged 14 commits into from
Sep 27, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Sep 20, 2019 •
edited
Loading

  • write a system test
  • add Kokoro configs in GitHub
  • add Kokoro configs in google3

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2019
@busunkim96 busunkim96 changed the title Generate recommender. Recommender: Generate v1beta1. Sep 20, 2019
@busunkim96 busunkim96 changed the title Recommender: Generate v1beta1. Recommender: Generate v1beta1 Sep 20, 2019
@busunkim96
Copy link
Contributor Author

The API endpoint is not yet publicly available, but has been enabled for the CI project.

@busunkim96 busunkim96 marked this pull request as ready for review September 23, 2019 19:08
@busunkim96 busunkim96 changed the title Recommender: Generate v1beta1 feat(recommender): generate v1beta1 Sep 25, 2019
tseaver
tseaver suggested changes Sep 27, 2019
View reviewed changes
recommender/docs/index.rst Show resolved Hide resolved
recommender/synth.py Outdated Show resolved Hide resolved
recommender/tests/system.py Outdated Show resolved Hide resolved
@busunkim96
Copy link
Contributor Author

Pulling out the system test for now as I think something needs to be tweaked in the backend.

@busunkim96 busunkim96 merged commit d07fb46 into googleapis:master Sep 27, 2019
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
feat(recommender): generate v1beta1 (#9257)
5674e04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tseaver @googlebot