Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firestore): Add support for OR query #20920

Merged
merged 14 commits into from
Apr 19, 2023
Merged

feat(firestore): Add support for OR query #20920

merged 14 commits into from
Apr 19, 2023

Conversation

diptanshumittal
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #<issue_number_goes_here>

@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Mar 16, 2023
@diptanshumittal
Copy link
Contributor Author

Presumbit acceptance tests failure is not related to these changes. Issue will be resolved in - #20926

@diptanshumittal diptanshumittal marked this pull request as ready for review March 27, 2023 04:29
@diptanshumittal diptanshumittal requested a review from a team as a code owner March 27, 2023 04:29
@SandeepTuniki SandeepTuniki mentioned this pull request Mar 29, 2023
Merged
SandeepTuniki
SandeepTuniki approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@SandeepTuniki SandeepTuniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diptanshumittal diptanshumittal added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2023
@diptanshumittal diptanshumittal merged commit d1859cf into main Apr 19, 2023
@diptanshumittal diptanshumittal deleted the feat_firestore_or_query branch April 19, 2023 13:56
@yoshi-code-bot yoshi-code-bot mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivedhaSenthil NivedhaSenthil NivedhaSenthil approved these changes

@SandeepTuniki SandeepTuniki SandeepTuniki approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diptanshumittal @NivedhaSenthil @SandeepTuniki @yoshi-kokoro