feat(datastore): Support OR filter #21002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
SandeepTuniki
changed the title
SandeepTuniki
force-pushed
the
datastore-or-filter
branch
from
7cf87e3
to
548f3f2
Compare
bajajneha27
reviewed
Mar 30, 2023
google-cloud-datastore/test/google/cloud/datastore/query_test.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
|
Hi @bajajneha27, I addressed all your comments. Can you please review the PR again? |
SandeepTuniki
force-pushed
the
datastore-or-filter
branch
from
69db0c9
to
46ea277
Compare
bajajneha27
approved these changes
Apr 4, 2023
google-cloud-datastore/test/google/cloud/datastore/query_test.rb
Outdated
Show resolved
Hide resolved
SandeepTuniki
force-pushed
the
datastore-or-filter
branch
from
e40d46f
to
0107c16
Compare
SandeepTuniki
force-pushed
the
datastore-or-filter
branch
from
283d21c
to
0eb1a5c
Compare
|
Hi @NivedhaSenthil, I addressed all your comments. Can you please review the PR again? |
NivedhaSenthil
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements "OR" query filter for
Datastore.Similar PR for Firestore is done in #20920.