Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compatibility with GA releases of underlying versioned clients #26361

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat: compatibility with GA releases of underlying versioned clients #26361

merged 2 commits into from
Jul 9, 2024

Conversation

aandreassa
Copy link
Contributor

No description provided.

@aandreassa aandreassa marked this pull request as ready for review July 9, 2024 20:59
@aandreassa aandreassa requested a review from dazuma July 9, 2024 21:12
dazuma
dazuma approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we should use feat: for this. The change is that it makes these clients compatible with 1.x versions of their GAPICs, so maybe something generic like feat: compatibility with GA releases of underlying versioned clients.

@aandreassa aandreassa merged commit f6c9c9d into main Jul 9, 2024
18 checks passed
@aandreassa aandreassa deleted the gapic-prerelease-gemspec branch July 9, 2024 21:20
@aandreassa aandreassa changed the title chore: Prepare wrapper dependencies for stable releases feat: compatibility with GA releases of underlying versioned clients Jul 9, 2024
@aandreassa
Copy link
Contributor Author

Changed PR title as well for posteriority.

This was referenced Jul 9, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@aandreassa aandreassa mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aandreassa @dazuma @yoshi-automation