Add additional values to results [Fixes #37 and #38] #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need updates I guess? |
Also make sure super is called with parens so that the overloaded constructor params are not sent as well.
Replace List with new QueryResults objects.
Include convenience methods for dealing with more_results on QueryResults. Include convenience methods for dealing with more_results on Proto.
|
Added some additional test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename List to Dataset::QueryResults, and add Query::LookupResults. Dataset::QueryResults has cursor and more_results. Query::LookupResults has deferred and missing.