Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run javadoc tests #524

Closed
chingor13 opened this issue Nov 8, 2018 · 3 comments
Closed

Run javadoc tests #524

chingor13 opened this issue Nov 8, 2018 · 3 comments
Assignees
@chingor13
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@chingor13
Copy link
Collaborator

We're currently skipping javadoc tests when running CI.

We may also need to set up a conditional profile for Java 8 for the Xdoclint option.
@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Nov 8, 2018
@chingor13 chingor13 self-assigned this Nov 8, 2018
@chingor13 chingor13 mentioned this issue Nov 8, 2018
Merged
1 task
@geri-m
Copy link
Contributor

geri-m commented Nov 8, 2018

I think <doclint>none</doclint> is what we are looking for (https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#doclint). I'll give it a shot.

geri-m added a commit to geri-m/google-http-java-client that referenced this issue Nov 8, 2018
@geri-m
Use doclint to skip checks of javadoc (googleapis#524)
8df8f01
@geri-m geri-m mentioned this issue Nov 8, 2018
Merged
1 task
@geri-m
Copy link
Contributor

geri-m commented Nov 8, 2018

JavaDoc generation triggered using JDK 7/8/11 looks okay. Currently I don't see a reason why to use a profile. @igorbernstein2 any comments or drawbacks you see here?

@igorbernstein2
Copy link

I didn't know about <doclint>. That's way better than my profile hack

chingor13 pushed a commit that referenced this issue Nov 8, 2018
@geri-m @chingor13
Skip Lint of JavaDoc (#525)
d7f18a3 
* Use doclint to skip checks of javadoc (#524)

* Remove comment out command (#522)
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@yoshi-automation
ci(java): ignore bot users for generate-files-bot (googleapis#524)
5e49463 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/5204afce-766b-4a81-9152-05f5c11b5df8/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@3f67cee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @geri-m @igorbernstein2