Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Automatic-Module-Name in MANIFEST.MF #400

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

ameya-pandilwar
Copy link
Contributor

Fixes #395

@ameya-pandilwar
Copy link
Contributor Author

Hi Matt (@mattwhisenhunt) - Could you review this pull request? Thanks!

@chingor13 chingor13 self-assigned this Aug 2, 2018
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting to this.

Should we be adding an entry to all of the artifacts?

@chingor13
Copy link
Collaborator

We can add any other ones in a separate PR.

@chingor13 chingor13 merged commit 2777514 into googleapis:dev Aug 29, 2018
This was referenced Oct 12, 2018
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
* updated versions.txt [ci skip]

* updated appengine/pom.xml [ci skip]

* updated bom/pom.xml [ci skip]

* updated credentials/pom.xml [ci skip]

* updated oauth2_http/pom.xml [ci skip]

* updated pom.xml [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants