Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for Java 10 #454

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Fix compilation for Java 10 #454

merged 1 commit into from
Aug 29, 2018

Conversation

chingor13
Copy link
Collaborator

  • Update datanucleus plugin versions to build on Java 9/10.
  • Update clirr-maven-plugin to 2.8 to work on Java 10.
  • Removing Java 9 from the test matrix as we cannot resolve the issue and guava does not seem to work on Java 9 anyways.

@chingor13 chingor13 requested a review from a team August 24, 2018 19:38
@chingor13
Copy link
Collaborator Author

The Java 9 test was removed internally and should not run on future PRs.

@chingor13 chingor13 requested a review from jeanbza August 27, 2018 21:52
Copy link
Member

@jeanbza jeanbza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the assembly versions, too? Also, this update will require syncing versions to the other two repos, assuming we don't split the release process soon.

@chingor13
Copy link
Collaborator Author

@jadekler The only versions that changed were the maven plugins which aren't included in the assembly - they only are used during the development and build process.

Copy link
Member

@jeanbza jeanbza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@chingor13 chingor13 merged commit d9c660f into googleapis:dev Aug 29, 2018
@chingor13 chingor13 deleted the java10 branch August 29, 2018 17:02
This was referenced Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants