Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to build HttpResponseException when charset is malformed #535

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Fix to build HttpResponseException when charset is malformed #535

merged 3 commits into from
Dec 11, 2018

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Dec 5, 2018

Fixes #323 IllegalCharsetNameException in HttpResponse getContentCharset() if charset is malformed

  • Tests pass
  • Appropriate docs were updated (if necessary)

@ajaaym ajaaym requested a review from a team as a code owner December 5, 2018 17:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
chingor13
chingor13 requested changes Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case for this?

google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java Outdated Show resolved Hide resolved
@ajaaym
Copy link
Contributor Author

ajaaym commented Dec 10, 2018

@chingor13 added test case. please take a look.

@chingor13 chingor13 merged commit 02a6040 into googleapis:master Dec 11, 2018
This was referenced Jan 3, 2019
Closed
Closed
Merged
yoshi-automation added a commit that referenced this pull request May 11, 2020
@yoshi-automation
chore: move ci.yaml to workflows dir (#535)
0708a31 
Source-Author: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Source-Date: Mon May 11 16:24:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 98c50772ec23295c64cf0d2ddf199ea52961fd4c
Source-Link: googleapis/synthtool@98c5077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajaaym @chingor13 @googlebot