Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MockBackOff#getMaxTries, returns maxTries #548

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Fixed MockBackOff#getMaxTries, returns maxTries #548

merged 1 commit into from
Dec 28, 2018

Conversation

sebfz1
Copy link
Contributor

@sebfz1 sebfz1 commented Dec 28, 2018

Fixes MockBackOff#getMaxTries which should return maxTries (instead of numTries)

  • Tests pass
  • Appropriate docs were updated (if necessary)

@sebfz1 sebfz1 requested a review from a team as a code owner December 28, 2018 14:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 28, 2018
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 28, 2018
@chingor13
Copy link
Collaborator

Thanks!

@chingor13 chingor13 merged commit ce27437 into googleapis:master Dec 28, 2018
This was referenced Jan 3, 2019
Closed
Closed
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@JustinBeckwith
build: migrate to flakybot (googleapis#548)
1fa9e1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebfz1 @chingor13 @googlebot @kokoro-team