Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iterable maps JSON serialization #550

Merged
merged 4 commits into from
Jan 3, 2019

Conversation

chingor13
Copy link
Collaborator

@chingor13 chingor13 commented Dec 28, 2018

From #404

If a map is iterable, then the JSON generator treats the map as an array when it should still be treated as a JSON object.

@chingor13 chingor13 requested a review from a team as a code owner December 28, 2018 18:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 28, 2018
Even if they are iterable, like clojure maps.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 28, 2018
@chingor13
Copy link
Collaborator Author

@mikekap signed the CLA for that commit in #404

@chingor13 chingor13 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 28, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mikekap
Copy link

mikekap commented Dec 28, 2018

Thanks for getting this one over the line @chingor13 !

@chingor13 chingor13 added the release blocking Required feature/issue must be fixed prior to next release. label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants