Update ApacheHttpTransport implementation #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
added
the
do not merge
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
added
the
release blocking
We are providing a subset of builder options and we cannot change setting after the HttpClient has been built. We should allow users to just provide their implementation via the constructor.
chingor13
changed the title
chingor13
removed
the
do not merge
kolea2
reviewed
Jan 4, 2019
...-http-client-apache/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java
Outdated
Show resolved
Hide resolved
kolea2
approved these changes
Jan 4, 2019
This was referenced Jan 7, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364
Fixes #482
Fixes #503
This rewrites the
ApacheHttpTransportto use non-deprecated functionality. In the upgrade, we lose ability to modify clients after the fact - they became read-only. Thus, we cannot enforce things like disabling retries on providedHttpClientimplementations.We now have 2 artifacts:
google-http-client-apache-legacy/which is the old one exactly which only works with the default implementation. This one will be available as version 1.28.0.google-http-client-apache/which "removes" functionality like the builder - users should opt for the builder provided by Apache HttpClient. It has breaking changes, so this one will be available as version 2.0.0.