Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

372: Changed SingleThreadExecutor to FixedThreadPool(1). #588

Merged
merged 2 commits into from
Feb 13, 2019
Merged

372: Changed SingleThreadExecutor to FixedThreadPool(1). #588

merged 2 commits into from
Feb 13, 2019

Conversation

andrey-qlogic
Copy link
Contributor

Fixes #372

@andrey-qlogic andrey-qlogic requested a review from a team as a code owner February 12, 2019 16:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
@sduskis
Copy link
Contributor

sduskis commented Feb 12, 2019

Does it make sense to use a daemon threads so that the requests do not block jvm shutdown?

@andrey-qlogic
Copy link
Contributor Author

@sduskis , good point, thanks

@sduskis sduskis merged commit cbecf1f into googleapis:master Feb 13, 2019
@kolea2 kolea2 mentioned this pull request Feb 25, 2019
Merged
@kolea2 kolea2 mentioned this pull request Mar 25, 2019
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@yoshi-automation
chore: copy README to docfx-yml dir (googleapis#588)
7cd534c 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/69766c45-5159-4300-b6d1-f7a09f78f2ab/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@d0bdade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

Assignees

@sduskis sduskis

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrey-qlogic @sduskis @googlebot