Revert #529 #662
Merged
Revert #529 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Map (googleapis#529)" This reverts commit da597e8.
googlebot
added
the
cla: yes
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
3 tasks
sduskis
approved these changes
Jun 2, 2019
This was referenced Jun 3, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts "Fix int type transformed as BigDecimal value when parsing as …Map (#529)"
This reverts commit da597e8.
See #664
This commit breaks many internal customers. It also now crashing when you pass it a very large integer. We can possibly try to parse as and Integer and if it overflows, then parse as a BigInteger or BigDecimal, but then as a consumer, you are unsure of what type of value you will see. We should revert this behavior and then add a unit test separately to prevent regression.