Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update release-please versioning to "always-bump-minor" #1082

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ddixit14
Copy link
Contributor

This versioning strategy always only bumps the minor version irrespective of the changes committed. We can remove this after the minor-version release and releases will fall back to default versioning strategy.
Reference: https://github.com/googleapis/release-please/blob/main/docs/customizing.md#versioning-strategies

This versioning strategy always only bumps the minor version irrespective of the changes committed. 
We can remove this after the minor-version release and things will fall back to default. 
https://github.com/googleapis/release-please/blob/main/docs/customizing.md#versioning-strategies
@ddixit14 ddixit14 requested review from a team as code owners November 20, 2023 15:33
Copy link

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 20, 2023
@ddixit14
Copy link
Contributor Author

release-please config schema is failing but it should be okay. Raised a PR to fix it in release-please source code. The versioning strategy should work irrespective of this schema failure.

Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @ddixit14

@TimurSadykov TimurSadykov merged commit 8c3c194 into main Dec 6, 2023
17 of 18 checks passed
@TimurSadykov TimurSadykov deleted the ddixit14-patch-1 branch December 6, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants