Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(packaging): update dev status to stable #142

Merged
merged 7 commits into from
Aug 24, 2020
Merged

chore(packaging): update dev status to stable #142

merged 7 commits into from
Aug 24, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 23, 2020 •
edited
Loading

@tseaver tseaver added status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like. labels Jul 23, 2020
@tseaver tseaver requested a review from busunkim96 July 23, 2020 18:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@tseaver tseaver requested a review from plamut July 23, 2020 18:54
plamut
plamut reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since promoting to stable, the library version should be bumped to 1.0.0, IIRC.

Possibly unrelated, but the docs linked to in the README are dated (version 0.4.1), might be worth publishing the most recent version.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 24, 2020

@plamut

Since promoting to stable, the library version should be bumped to 1.0.0, IIRC.

The Release-As: 1.0 tag in the commit is supposed to do that, I think.

Possibly unrelated, but the docs linked to in the README are dated (version 0.4.1), might be worth publishing the most recent version.

I've marked this PR as blocked on #137, which involves an overall docs cleanup.

@plamut
Copy link
Contributor

plamut commented Jul 24, 2020 •
edited
Loading

The Release-As: 1.0 tag in the commit is supposed to do that, I think.

What about PyPI, doesn't it take the version label from setup.py? If nothing else, it would look confusing to have a 1.0 library with a different version specified in its setup.py.

@busunkim96
Copy link
Contributor

@plamut After this PR is merged release-please will open a new PR with 1.0.0.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 28, 2020 •
edited
Loading

Systest failures in cleanup functions (unexpected 429 / 409), reported as #150.

@tseaver tseaver added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Jul 29, 2020

@plamut, @busunkim96 I believe this issue is ready for review.

@busunkim96 busunkim96 closed this Jul 31, 2020
plamut
plamut reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all blockers have been resolved.

@busunkim96 busunkim96 reopened this Aug 4, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Aug 4, 2020

@busunkim96 PTAL

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@tseaver tseaver removed the status: blocked Resolving the issue is dependent on other work. label Aug 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@tseaver tseaver mentioned this pull request Aug 24, 2020
Merged
@tseaver tseaver requested a review from frankyn August 24, 2020 21:17
@tseaver tseaver merged commit 06a4231 into master Aug 24, 2020
@tseaver tseaver deleted the 138-packaging-bump-to-1.0.0 branch August 24, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release as production/stable
5 participants
@tseaver @plamut @busunkim96 @tmatsuo @yoshi-kokoro