Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish docs to googleapis.dev #145

Merged
merged 3 commits into from
Jul 28, 2020
Merged

chore: publish docs to googleapis.dev #145

merged 3 commits into from
Jul 28, 2020

Conversation

busunkim96
Copy link
Contributor

Closes #137

Removes the existing infrastructure to generate the docs and uses the standard template/format in other client libraries.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2020
@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2020

The doctests build failed:

Running session doctest
Creating virtual environment (virtualenv) using python3.8 in .nox/doctest
cd /tmpfs/src/github/google-resumable-media-python
pip install sphinx sphinx_rtd_theme sphinx-docstring-typing >= 0.0.3 mock google-auth >= 0.10.0
pip install -e .[requests]
sphinx-build -W -b doctest -d docs_build/build/doctrees docs_build docs_build/doctest

Application error:
config directory doesn't contain a conf.py file (docs_build)
Command sphinx-build -W -b doctest -d docs_build/build/doctrees docs_build docs_build/doctest failed with exit code 2
Session doctest failed.

@google-cla
Copy link

google-cla bot commented Jul 28, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 28, 2020
@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2020

@googlebot I consent.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 28, 2020
@tseaver tseaver merged commit 3c684d3 into master Jul 28, 2020
@tseaver tseaver deleted the standardize-docs branch July 28, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move documentation to googleapis.dev
2 participants