New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Improve code coverage for Acl #490
Merged
stephaniewang526
merged 2 commits into
googleapis:master
from
irvifa:improve-coverage-for-acl
Jun 29, 2020
Merged
test: Improve code coverage for Acl #490
stephaniewang526
merged 2 commits into
googleapis:master
from
irvifa:improve-coverage-for-acl
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
============================================
+ Coverage 81.36% 81.48% +0.12%
Complexity 1225 1225
============================================
Files 77 77
Lines 6218 6218
Branches 691 691
============================================
+ Hits 5059 5067 +8
+ Misses 802 792 -10
- Partials 357 359 +2
Continue to review full report at Codecov.
|
irvifa
force-pushed
the
improve-coverage-for-acl
branch
from
June 26, 2020 18:24
2b41026
to
743dd6e
Compare
irvifa
changed the title
cleanup: Improve code coverage for Acl
test: Improve code coverage for Acl
Jun 26, 2020
In Acl there's still untested class particularly the IamMember. Also we can still improve the coverage by improving test for Group.
irvifa
force-pushed
the
improve-coverage-for-acl
branch
from
June 26, 2020 18:28
743dd6e
to
c033720
Compare
stephaniewang526
approved these changes
Jun 26, 2020
stephaniewang526
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 26, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 26, 2020
Somehow got flaky test on:
|
pmakani
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 28, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 28, 2020
Since nearly every table is using env var, there's a possibility of concurrency problem in the test.
irvifa
force-pushed
the
improve-coverage-for-acl
branch
from
June 29, 2020 06:22
2b06532
to
53cbd82
Compare
pmakani
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 29, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Acl there's still untested class particularly the IamMember. Also we can still improve the coverage by improving test for Group.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #489 ☕️