Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve code coverage for Acl #490

Merged
merged 2 commits into from Jun 29, 2020

Conversation

irvifa
Copy link
Contributor

@irvifa irvifa commented Jun 26, 2020

In Acl there's still untested class particularly the IamMember. Also we can still improve the coverage by improving test for Group.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #489 ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #490 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #490      +/-   ##
============================================
+ Coverage     81.36%   81.48%   +0.12%     
  Complexity     1225     1225              
============================================
  Files            77       77              
  Lines          6218     6218              
  Branches        691      691              
============================================
+ Hits           5059     5067       +8     
+ Misses          802      792      -10     
- Partials        357      359       +2     
Impacted Files Coverage Δ Complexity Δ
...y/src/main/java/com/google/cloud/bigquery/Acl.java 71.42% <0.00%> (+6.01%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a2bea...53cbd82. Read the comment docs.

@irvifa irvifa changed the title cleanup: Improve code coverage for Acl test: Improve code coverage for Acl Jun 26, 2020
In Acl there's still untested class particularly the IamMember.
Also we can still improve the coverage by improving test for Group.
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2020
@irvifa
Copy link
Contributor Author

irvifa commented Jun 26, 2020

Somehow got flaky test on:

com.google.common.truth.AssertionErrorWithFacts:
expected to contain:
    Empty column successfully added to table
but was:
    Empty column was not added.
    com.google.cloud.bigquery.BigQueryException: Provided Schema does not match Table java-docs-samples-testing:bigquery_test_dataset.test_table. Field new_896e1c11_8ba3_4037_a2de_f6d76ea69e53 is missing in new schema

	at com.example.bigquery.AddEmptyColumnIT.addEmptyColumn(AddEmptyColumnIT.java:65)

https://source.cloud.google.com/results/invocations/9eac7d0a-69ed-4040-beb9-40f796ec7d83/targets;collapsed=/github%2Fjava-bigquery%2Fsamples%2Finstall-without-bom%2Ftarget%2Ffailsafe-reports/tests

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2020
Since nearly every table is using env var,
there's a possibility of concurrency problem in the test.
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2020
@stephaniewang526 stephaniewang526 merged commit 84237c5 into googleapis:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Improve code coverage for Acl
5 participants