Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sql fast path impl #509

Merged
merged 25 commits into from Sep 22, 2020
Merged

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jul 4, 2020

Expose backend query() method in the client when QueryJobConfiguration is supported by QueryRequest

cc: @gcasto

@stephaniewang526 stephaniewang526 requested a review from shollyman Jul 4, 2020
@googlebot googlebot added the cla: yes label Jul 4, 2020
@stephaniewang526 stephaniewang526 requested a review from pmakani Jul 4, 2020
@pmakani pmakani added the kokoro:force-run label Jul 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 4, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 6, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 7, 2020

Codecov Report

Merging #509 into master will decrease coverage by 0.12%.
The diff coverage is 74.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #509      +/-   ##
============================================
- Coverage     81.07%   80.94%   -0.13%     
- Complexity     1236     1261      +25     
============================================
  Files            78       79       +1     
  Lines          6334     6465     +131     
  Branches        705      735      +30     
============================================
+ Hits           5135     5233      +98     
- Misses          833      844      +11     
- Partials        366      388      +22     
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/bigquery/BigQueryError.java 88.09% <ø> (ø) 14.00 <0.00> (ø)
.../com/google/cloud/bigquery/spi/v2/BigQueryRpc.java 82.60% <ø> (ø) 0.00 <0.00> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 4.90% <0.00%> (-0.05%) 2.00 <0.00> (ø)
...a/com/google/cloud/bigquery/BigQueryException.java 74.28% <64.28%> (-5.03%) 14.00 <5.00> (+3.00) ⬇️
...va/com/google/cloud/bigquery/QueryRequestInfo.java 73.13% <73.13%> (ø) 14.00 <14.00> (?)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 82.83% <80.00%> (-0.07%) 84.00 <6.00> (+7.00) ⬇️
...m/google/cloud/bigquery/QueryJobConfiguration.java 90.21% <100.00%> (+0.13%) 67.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ca177...e161cf9. Read the comment docs.

@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 7, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 9, 2020
add QueryJobConfig to QueryRequest logic

high level mode

reset private methods

refactor: modified code

update logic
add test

refactor: update code and test case

add integration tests

code format

add clir ignore and remove pom file

feat: add more assert

nit update
enable requestId
add integration tests for fast path multipages query, DML, and DDL queries

fix requestId logic

update QueryRequestInfo and add mock test

add mock test cases for SQL, DML, and DDL
clean up code

fix IT

add schema test
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 10, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 16, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Aug 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 28, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Sep 3, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no cla: yes and removed cla: yes cla: no labels Sep 3, 2020
Copy link

@epavan123 epavan123 left a comment

There are a number of warnings about uncovered lines. Please add tests to cover those.

to address:
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryException.java#L69-L71
Added lines #L69 - L71 were not covered by tests
@epavan123
Copy link

@epavan123 epavan123 commented Sep 7, 2020

Hi,

Please hold on to the CL, I am looking into the interaction of this with some ongoing work to increase max row size limits.

@stephaniewang526 stephaniewang526 added the do not merge label Sep 7, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Sep 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 16, 2020
@stephaniewang526
Copy link
Member Author

@stephaniewang526 stephaniewang526 commented Sep 18, 2020

There are a number of warnings about uncovered lines. Please add tests to cover those.

Added more test coverage wherever possible.

@stephaniewang526 stephaniewang526 merged commit 64a7d65 into googleapis:master Sep 22, 2020
16 of 18 checks passed
@meredithslota meredithslota removed the do not merge label Oct 13, 2020
@googleapis googleapis deleted a comment from pmakani Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants