Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 #1365

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 19, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-shared-dependencies 2.3.0 -> 2.4.0 age adoption passing confidence

Release Notes

googleapis/java-shared-dependencies

v2.4.0

Compare Source

Dependencies
  • update dependency com.fasterxml.jackson:jackson-bom to v2.13.0 (dba11b5)
  • update dependency com.google.api-client:google-api-client-bom to v1.32.2 (dba11b5)
  • update dependency com.google.api:api-common to v2.0.5 (dba11b5)
  • update dependency com.google.auth:google-auth-library-bom to v1.2.1 (dba11b5)
  • update dependency com.google.guava:guava-bom to v31 (#​498) (dba11b5)
  • update dependency com.google.http-client:google-http-client-bom to v1.40.1 (dba11b5)
  • update dependency com.google.protobuf:protobuf-bom to v3.18.1 (#​494) (a30e376)
  • update dependency io.grpc:grpc-bom to v1.41.0 (#​482) (8a7d227)
  • update gax.version to v2.6.1 (dba11b5)
  • update iam.version to v1.1.6 (#​485) (cef7e09)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from as code owners Oct 19, 2021
@renovate-bot renovate-bot requested a review from tswast (assigned from googleapis/api-bigquery) Oct 19, 2021
@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@suztomo
Copy link
Member

@suztomo suztomo commented Oct 19, 2021

****************** DEPENDENCY LIST COMPLETENESS CHECK *******************
~/work/java-bigquerystorage/java-bigquerystorage/google-cloud-bigquerystorage ~/work/java-bigquerystorage/java-bigquerystorage
2021-10-19 03:40:39 Generating dependency list using original pom...
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
2021-10-19 03:40:41 Generating dependency list using flattened pom...
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
2021-10-19 03:40:46 Comparing dependency lists...
2021-10-19 03:40:46 Diff found. See below: 
2021-10-19 03:40:46 You can also check .diff.txt file located in google-cloud-bigquerystorage.
37c37
< [INFO]    io.opencensus:opencensus-api:jar:0.28.0:runtime
---
> [INFO]    io.opencensus:opencensus-api:jar:0.28.0:compile

The failure comes from diff .org-list.txt .new-list.txt

suztomo@suztomo:~/java-bigquerystorage/google-cloud-bigquerystorage$ cat .org-list.txt  |grep opencensus
[INFO]    io.opencensus:opencensus-api:jar:0.28.0:runtime
suztomo@suztomo:~/java-bigquerystorage/google-cloud-bigquerystorage$ cat .new-list.txt  |grep opencensus
[INFO]    io.opencensus:opencensus-api:jar:0.28.0:compile

So the original pom.xml gives runtime scope for opencensus-api while the flattened pom.xml gives opencensus-api as compile scope. Because the google-cloud-bigquerystorage module does not have any reference to io.opencensus-api, this shouldn't cause any problem to library users.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Oct 19, 2021

****************** DEPENDENCY LIST COMPLETENESS CHECK *******************
~/work/java-bigquerystorage/java-bigquerystorage/google-cloud-bigquerystorage ~/work/java-bigquerystorage/java-bigquerystorage
2021-10-19 03:40:39 Generating dependency list using original pom...
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
2021-10-19 03:40:41 Generating dependency list using flattened pom...
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
2021-10-19 03:40:46 Comparing dependency lists...
2021-10-19 03:40:46 Diff found. See below: 
2021-10-19 03:40:46 You can also check .diff.txt file located in google-cloud-bigquerystorage.
37c37
< [INFO]    io.opencensus:opencensus-api:jar:0.28.0:runtime
---
> [INFO]    io.opencensus:opencensus-api:jar:0.28.0:compile

The failure comes from diff .org-list.txt .new-list.txt

suztomo@suztomo:~/java-bigquerystorage/google-cloud-bigquerystorage$ cat .org-list.txt  |grep opencensus
[INFO]    io.opencensus:opencensus-api:jar:0.28.0:runtime
suztomo@suztomo:~/java-bigquerystorage/google-cloud-bigquerystorage$ cat .new-list.txt  |grep opencensus
[INFO]    io.opencensus:opencensus-api:jar:0.28.0:compile

So the original pom.xml gives runtime scope for opencensus-api while the flattened pom.xml gives opencensus-api as compile scope. Because the google-cloud-bigquerystorage module does not have any reference to io.opencensus-api, this shouldn't cause any problem to library users.

Thanks for the analysis, Tomo. I agree. I will exclude this dep in the comparison in this repo.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Oct 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 19, 2021
@stephaniewang526 stephaniewang526 added the automerge label Oct 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 69e96aa into googleapis:main Oct 19, 2021
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 19, 2021
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-google-cloud-shared-dependencies-2.x branch Oct 19, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants