Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for StorageError #1391

Merged
merged 19 commits into from Nov 15, 2021
Merged

feat: add support for StorageError #1391

merged 19 commits into from Nov 15, 2021

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Oct 29, 2021

Fixes b/203003176

@stephaniewang526 stephaniewang526 requested a review from as a code owner Oct 29, 2021
@stephaniewang526 stephaniewang526 requested a review from shollyman (assigned from googleapis/api-bigquery) Oct 29, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Oct 29, 2021
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@stephaniewang526 stephaniewang526 requested a review from yirutang Oct 29, 2021
@stephaniewang526 stephaniewang526 requested a review from as a code owner Oct 29, 2021
Copy link
Contributor

@yirutang yirutang left a comment

Looks good, but there is a missing part, is there a way to add the same process when the API call failed, aka, in terms of connection error?

It is when the Done function is called on AppendRows.

@stephaniewang526 stephaniewang526 requested a review from yirutang Nov 1, 2021
@stephaniewang526 stephaniewang526 requested a review from yirutang Nov 2, 2021
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Two bugs, and the reason your tests builds are all hung and will likely need to timeout.

An exception is being thrown because the map is null while trying to initialize the exception most likely going into a loop or something.

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Copy link
Contributor

@yirutang yirutang left a comment

Thanks!

@stephaniewang526 stephaniewang526 added the automerge label Nov 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants