Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DATE and DOUBLE support more input formats #1397

Merged
merged 1 commit into from Nov 9, 2021

Conversation

burakgok
Copy link
Contributor

@burakgok burakgok commented Nov 3, 2021

Fixes #1396

  1. Long values are converted into Integer for DATE fields.
  2. Date literals are converted into epoch days (Integer) for DATE fields.
  3. Number values are converted into Double for DOUBLE fields.

@burakgok burakgok requested a review from as a code owner Nov 3, 2021
@burakgok burakgok requested a review from stephaniewang526 (assigned from googleapis/api-bigquery) Nov 3, 2021
@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Nov 3, 2021
@burakgok burakgok changed the title DATE and DOUBLE support more input formats feat: DATE and DOUBLE support more input formats Nov 3, 2021
@yirutang
Copy link
Contributor

@yirutang yirutang commented Nov 3, 2021

Looks great! Could you add unit test for the extra cases supported?
Date with String
Date with Long
Double with Integer

Copy link
Contributor

@yirutang yirutang left a comment

Thanks!

@stephaniewang526 stephaniewang526 added kokoro:force-run automerge labels Nov 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 5, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Nov 5, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Nov 5, 2021
@stephaniewang526 stephaniewang526 removed the automerge label Nov 5, 2021
1. Long values are converted into Integer for DATE fields.
2. Date literals are converted into epoch days (Integer) for DATE fields.
3. Number values are converted into Double for DOUBLE fields.
@stephaniewang526 stephaniewang526 added the owlbot:run label Nov 9, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Nov 9, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run owlbot:run labels Nov 9, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Nov 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants