Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renamed SchemaCompact.java to SchemaCompatibility.java #362

Merged

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jun 18, 2020

Renamed SchemaCompact.java to SchemaCompatibility.java and changed all instances of SchemaCompact to be SchemaCompatibility in other files.

@googlebot googlebot added the cla: yes label Jun 18, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 18, 2020

Codecov Report

Merging #362 into master will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #362   +/-   ##
=========================================
  Coverage     76.38%   76.38%           
  Complexity      554      554           
=========================================
  Files            54       54           
  Lines          3261     3261           
  Branches        196      196           
=========================================
  Hits           2491     2491           
  Misses          660      660           
  Partials        110      110           
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 79.31% <ø> (ø) 5.00 <0.00> (ø)
...e/cloud/bigquery/storage/v1alpha2/WriterCache.java 91.76% <50.00%> (ø) 14.00 <1.00> (ø)
...bigquery/storage/v1alpha2/SchemaCompatibility.java 91.19% <66.66%> (ø) 96.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c55e9...db05ec2. Read the comment docs.

@allenc3 allenc3 changed the title refactor: Renamed SchemaCompact.java to SchemaCompatibility.java fix: Renamed SchemaCompact.java to SchemaCompatibility.java Jun 18, 2020
@allenc3 allenc3 marked this pull request as ready for review Jun 19, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jun 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 19, 2020
@stephaniewang526 stephaniewang526 merged commit d3f4787 into googleapis:master Jun 20, 2020
13 of 14 checks passed
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this issue Jul 16, 2020
…is#362)

* Renaming SchemaCompact.java to SchemaCompatibility.java, and changed all instances of SchemaCompact.

* Update clirr-ignore file

* Fixed class name

* Fix small typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants