Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BQ Numeric is compatible with double and float protobuf types #367

Merged
merged 2 commits into from Jun 22, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jun 22, 2020

Fixed a bug and made BQ Numeric compatible with double and float protobuf types.

@googlebot googlebot added the cla: yes label Jun 22, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 22, 2020

Codecov Report

Merging #367 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #367      +/-   ##
============================================
+ Coverage     76.38%   76.40%   +0.01%     
- Complexity      554      556       +2     
============================================
  Files            54       54              
  Lines          3261     3263       +2     
  Branches        196      197       +1     
============================================
+ Hits           2491     2493       +2     
  Misses          660      660              
  Partials        110      110              
Impacted Files Coverage Δ Complexity Δ
...bigquery/storage/v1alpha2/SchemaCompatibility.java 91.30% <100.00%> (+0.10%) 98.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700ee5a...c0cf3b1. Read the comment docs.

@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jun 22, 2020
@stephaniewang526 stephaniewang526 added the automerge label Jun 22, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run labels Jun 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1b2f110 into googleapis:master Jun 22, 2020
11 of 14 checks passed
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this issue Jul 16, 2020
…oogleapis#367)

Fixed a bug and made BQ Numeric compatible with double and float protobuf types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants