Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove stream ttl in client library, since there is no very clear TTL defined. #627

Merged
merged 4 commits into from Oct 22, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Oct 22, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Oct 22, 2020
@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 22, 2020

Codecov Report

Merging #627 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #627      +/-   ##
============================================
+ Coverage     78.63%   78.73%   +0.09%     
+ Complexity      663      660       -3     
============================================
  Files            59       59              
  Lines          3782     3766      -16     
  Branches        253      249       -4     
============================================
- Hits           2974     2965       -9     
+ Misses          692      689       -3     
+ Partials        116      112       -4     
Impacted Files Coverage Δ Complexity Δ
...ud/bigquery/storage/v1alpha2/JsonStreamWriter.java 77.19% <ø> (-0.20%) 12.00 <0.00> (-1.00)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 84.31% <ø> (+0.27%) 37.00 <0.00> (-2.00) ⬆️
...oud/bigquery/storage/v1alpha2/JsonWriterCache.java 91.07% <100.00%> (+3.14%) 12.00 <0.00> (ø)
...e/cloud/bigquery/storage/v1alpha2/WriterCache.java 94.25% <100.00%> (+2.11%) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6347c13...571dae2. Read the comment docs.

@yirutang yirutang requested a review from as a code owner Oct 22, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Oct 22, 2020
@stephaniewang526 stephaniewang526 merged commit 2ae69b6 into googleapis:master Oct 22, 2020
18 of 19 checks passed
@yirutang yirutang deleted the remove-ttl branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants