deps: remove client-core dependency from bigtable-hbase-2.x #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
gcf-owl-bot
bot
removed
the
owlbot:run
vermas2012
approved these changes
May 12, 2022
| BigtableInstanceName bigtableInstanceName = | ||
| new BigtableInstanceName( | ||
| bigtableSnapshotClusterName = | ||
| ClusterName.of( |
There was a problem hiding this comment.
please use NameUtil from veneer
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| @@ -86,7 +85,7 @@ public abstract class BigtableAsyncAdmin implements AsyncAdmin { | |||
| private final BigtableHBaseSettings settings; | |||
| private final CommonConnection asyncConnection; | |||
| private final String bigtableInstanceName; | |||
| private BigtableClusterName bigtableSnapshotClusterName; | |||
| private String bigtableSnapshotClusterName; | |||
Comment on lines
100
to
104
| String clusterId = | ||
| configuration.get(BigtableOptionsFactory.BIGTABLE_SNAPSHOT_CLUSTER_ID_KEY, null); | ||
| if (clusterId != null) { | ||
| BigtableInstanceName bigtableInstanceName = | ||
| new BigtableInstanceName( | ||
| asyncConnection.getBigtableSettings().getProjectId(), | ||
| asyncConnection.getBigtableSettings().getInstanceId()); | ||
| bigtableSnapshotClusterName = bigtableInstanceName.toClusterName(clusterId); | ||
| bigtableSnapshotClusterName = clusterId; | ||
| } |
There was a problem hiding this comment.
can you just assign it?
| @@ -517,7 +512,7 @@ private static <T> List<T> filter(Collection<T> r, Predicate<T> predicate) { | |||
| return r.stream().filter(predicate).collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| private synchronized BigtableClusterName getBackupClusterName() { | |||
| private synchronized String getBackupClusterName() { | |||
There was a problem hiding this comment.
getBackupClusterId()
Name == is the fully qualified name: projects/my-project/instances/my-instance/clusters/my-clsuter
Id = is the short identifier: my-cluster
| @@ -86,7 +84,7 @@ public abstract class BigtableAsyncAdmin implements AsyncAdmin { | |||
| private final BigtableHBaseSettings settings; | |||
| private final CommonConnection asyncConnection; | |||
| private final String bigtableInstanceName; | |||
| private BigtableClusterName bigtableSnapshotClusterName; | |||
| private String bigtableSnapshotClusterId; | |||
There was a problem hiding this comment.
nit. I dont think bigtable prefix is necessary here...I think its inferred from the context
Comment on lines
99
to
103
| String clusterId = | ||
| configuration.get(BigtableOptionsFactory.BIGTABLE_SNAPSHOT_CLUSTER_ID_KEY, null); | ||
| if (clusterId != null) { | ||
| BigtableInstanceName bigtableInstanceName = | ||
| new BigtableInstanceName( | ||
| asyncConnection.getBigtableSettings().getProjectId(), | ||
| asyncConnection.getBigtableSettings().getInstanceId()); | ||
| bigtableSnapshotClusterName = bigtableInstanceName.toClusterName(clusterId); | ||
| bigtableSnapshotClusterId = clusterId; | ||
| } |
There was a problem hiding this comment.
I dont think the if statement is relevant any more
gcf-owl-bot
bot
removed
the
owlbot:run
.../bigtable-hbase-2.x/src/main/java/com/google/cloud/bigtable/hbase2_x/BigtableAsyncAdmin.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
May 13, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 18, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](v2.2.0...v2.3.0) (2022-05-18) ### Features * add enableSnappy flag to import snapshot pipeline and select th… ([#3586](#3586)) ([8c1854d](8c1854d)) ### Dependencies * remove client-core dependency from bigtable-hbase-2.x ([#3620](#3620)) ([413a2fd](413a2fd)) ### Documentation * Update README to use --enableSnappy flag to import snappy compre… ([#3623](#3623)) ([ea73be9](ea73be9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.