feat: add enableSnappy flag to import snapshot pipeline and select th… #3586

TracyCuiCan · 2022-04-20T17:24:40Z

…e right container image based on beam version if flag is set.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

…e right container image based on beam version if flag is set.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

vermas2012

Overall looks good, minor comments

Lets validate that "--enableSnappy" is ok with Igor

...port/src/test/integration-test/data/.hbase-snapshot/snappy-compressed-snapshot/.snapshotinfo

.../src/main/java/com/google/cloud/bigtable/beam/hbasesnapshots/ImportJobFromHbaseSnapshot.java

clirr-ignored-differences.xml

…test.

.../src/main/java/com/google/cloud/bigtable/beam/hbasesnapshots/ImportJobFromHbaseSnapshot.java

...able-beam-import/src/test/java/com/google/cloud/bigtable/beam/hbasesnapshots/EndToEndIT.java

clirr-ignored-differences.xml

vermas2012

Please update the data generation script. https://paste.googleplex.com/5670577017716736

The generated zip file is at <>

...able-beam-import/src/test/java/com/google/cloud/bigtable/beam/hbasesnapshots/EndToEndIT.java

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-merge-on-green · 2022-05-10T03:22:12Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

...able-beam-import/src/test/java/com/google/cloud/bigtable/beam/hbasesnapshots/EndToEndIT.java

gcf-merge-on-green · 2022-05-11T03:52:13Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

🤖 I have created a release *beep* *boop* --- ## [2.3.0](v2.2.0...v2.3.0) (2022-05-18) ### Features * add enableSnappy flag to import snapshot pipeline and select th… ([#3586](#3586)) ([8c1854d](8c1854d)) ### Dependencies * remove client-core dependency from bigtable-hbase-2.x ([#3620](#3620)) ([413a2fd](413a2fd)) ### Documentation * Update README to use --enableSnappy flag to import snappy compre… ([#3623](#3623)) ([ea73be9](ea73be9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat: add enableSnappy flag to import snapshot pipeline and select th…

ed015bd

…e right container image based on beam version if flag is set.

TracyCuiCan requested a review from a team as a code owner April 20, 2022 17:24

product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Apr 20, 2022

vermas2012 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 25, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2022

🦉 Updates from OwlBot post-processor

a919287

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2022

vermas2012 reviewed Apr 25, 2022

View reviewed changes

TracyCuiCan and others added 3 commits April 28, 2022 12:30

Merge branch 'googleapis:main' into main

d7acbb0

Use DataflowServiceOptions for runner_v2 and update snapshot name in …

18cfb88

…test.

resolving conflicts

7308361

vermas2012 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2022

vermas2012 reviewed May 3, 2022

View reviewed changes

.../src/main/java/com/google/cloud/bigtable/beam/hbasesnapshots/ImportJobFromHbaseSnapshot.java Show resolved Hide resolved

Merge branch 'googleapis:main' into main

5340daa

igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2022

TracyCuiCan and others added 3 commits May 6, 2022 11:32

Merge branch 'googleapis:main' into main

1605a15

Merge branch 'googleapis:main' into main

7741a34

Resolve merge conflict and update E2E test.

9dc8ad5

igorbernstein2 reviewed May 6, 2022

View reviewed changes

vermas2012 requested changes May 6, 2022

View reviewed changes

...able-beam-import/src/test/java/com/google/cloud/bigtable/beam/hbasesnapshots/EndToEndIT.java Show resolved Hide resolved

TracyCuiCan and others added 2 commits May 8, 2022 14:18

Merge branch 'googleapis:main' into main

a188b33

address comments

456b7c4

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 8, 2022

vermas2012 approved these changes May 9, 2022

View reviewed changes

vermas2012 added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2022

vermas2012 added the automerge Merge the pull request once unit tests and other checks pass. label May 9, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2022

🦉 Updates from OwlBot post-processor

b519c01

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2022

vermas2012 added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 10, 2022

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 10, 2022

igorbernstein2 reviewed May 10, 2022

View reviewed changes

...able-beam-import/src/test/java/com/google/cloud/bigtable/beam/hbasesnapshots/EndToEndIT.java Outdated Show resolved Hide resolved

upload correct zip file.

3eb5d1b

vermas2012 added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 10, 2022

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 10, 2022

vermas2012 added the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2022

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 11, 2022

Fix clirr and address comment.

05ba50f

vermas2012 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2022

Filter by job name and add back pagination in snappy snapshot test.

816734c

vermas2012 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2022

vermas2012 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 16, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2022

vermas2012 merged commit 8c1854d into googleapis:main May 16, 2022

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 16, 2022

release-please bot mentioned this pull request May 16, 2022

chore(main): release 2.3.0 #3622

Merged

mutianf added a commit to mutianf/java-bigtable-hbase that referenced this pull request Jul 20, 2022

fix beam test according to googleapis#3586

c5e9aab

mutianf mentioned this pull request Aug 8, 2022

chore: relocate bigtable-client-core configurations to bigtable-clien… #3685

Merged

mutianf added a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022

fix beam test according to googleapis#3586

20ff390

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add enableSnappy flag to import snapshot pipeline and select th… #3586

feat: add enableSnappy flag to import snapshot pipeline and select th… #3586

TracyCuiCan commented Apr 20, 2022

vermas2012 left a comment

vermas2012 left a comment •

edited

Loading

gcf-merge-on-green bot commented May 10, 2022

gcf-merge-on-green bot commented May 11, 2022

feat: add enableSnappy flag to import snapshot pipeline and select th… #3586

feat: add enableSnappy flag to import snapshot pipeline and select th… #3586

Conversation

TracyCuiCan commented Apr 20, 2022

vermas2012 left a comment

Choose a reason for hiding this comment

vermas2012 left a comment • edited Loading

Choose a reason for hiding this comment

gcf-merge-on-green bot commented May 10, 2022

gcf-merge-on-green bot commented May 11, 2022

vermas2012 left a comment •

edited

Loading