Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:Update README to use --enableSnappy flag to import snappy compre… #3623

Merged
merged 3 commits into from
May 18, 2022
Merged

docs:Update README to use --enableSnappy flag to import snappy compre… #3623

merged 3 commits into from
May 18, 2022

Conversation

TracyCuiCan
Copy link
Contributor

…ssed snapshots.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@TracyCuiCan TracyCuiCan requested a review from a team as a code owner May 16, 2022 22:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels May 16, 2022
vermas2012
vermas2012 approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@vermas2012 vermas2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just double check with Igor if we should use the snapshot versions or the released versions in readme. Previously, we had beam-import-shaded-2.0.0.jar (no SNAPSHOT).

@vermas2012 vermas2012 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 17, 2022
igorbernstein2
igorbernstein2 approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vermas2012 vermas2012 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2022
@vermas2012 vermas2012 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ea73be9 into googleapis:main May 18, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 18, 2022
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 18, 2022
@release-please
chore(main): release 2.3.0 (#3622)
a16f89c 
🤖 I have created a release *beep* *boop*
---


## [2.3.0](v2.2.0...v2.3.0) (2022-05-18)


### Features

* add enableSnappy flag to import snapshot pipeline and select th… ([#3586](#3586)) ([8c1854d](8c1854d))


### Dependencies

* remove client-core dependency from bigtable-hbase-2.x ([#3620](#3620)) ([413a2fd](413a2fd))


### Documentation

* Update README to use --enableSnappy flag to import snappy compre… ([#3623](#3623)) ([ea73be9](ea73be9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@vermas2012 vermas2012 vermas2012 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TracyCuiCan @igorbernstein2 @vermas2012 @yoshi-kokoro