feat: use concrete classes for hbase.client.registry.impl #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used runtime bytecode generation which prevented endusers from using hbase-site.xml to target bigtable in hbase 2 applications Change-Id: I28c28683419ac8f65bccfa770ab7f0e1cc1a4d2f
product-auto-label
bot
added
size: l
Change-Id: Ia58e2cbcbafa57e08a7f710dd5a5b4d3a4e4bf68
product-auto-label
bot
added
size: xl
Change-Id: I452043b55373c1d41024893f5a9781853c9edae7
Change-Id: I9de88c819e110e521bdef638d40c63df36ac605b
mutianf
approved these changes
Mar 31, 2023
igorbernstein2
added a commit
to igorbernstein2/cloud-bigtable-client
that referenced
this pull request
Oct 16, 2023
…#4043) * feat: use concrete classes for hbase.client.registry.impl Previously we used runtime bytecode generation which prevented endusers from using hbase-site.xml to target bigtable in hbase 2 applications Change-Id: I28c28683419ac8f65bccfa770ab7f0e1cc1a4d2f * address feedback Change-Id: Ia58e2cbcbafa57e08a7f710dd5a5b4d3a4e4bf68 * add missing exclue Change-Id: I452043b55373c1d41024893f5a9781853c9edae7 * wip Change-Id: I03ab0a4283d430de45417807309498a976e32932 * fix bad rebase Change-Id: I9de88c819e110e521bdef638d40c63df36ac605b
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
) Previously we used runtime bytecode generation which prevented endusers from using hbase-site.xml to target bigtable in hbase 2 applications. This PR will create a concrete implementation for both AsyncRegistry for (hbase < 2.3) and ConnectionRegistry (for hbase >= 2.3). To accomplish this, we use a local copy of the AsyncRegistry interface from HBase 2.2 that we use as a compile time target and then strip it from the resulting jar. After this change end users should be able to use async apis in hbase 2 using hbase-site.xml. Examples: ```xml <configuration> <property> <name>hbase.client.connection.impl</name> <value>com.google.cloud.bigtable.hbase2_x.BigtableConnection</value> </property> <property> <name>hbase.client.async.connection.impl</name> <value>org.apache.hadoop.hbase.client.BigtableAsyncConnection</value> </property> <property> <name>hbase.client.registry.impl</name> <!-- When using hbase >= 2.3, use this --> <value>org.apache.hadoop.hbase.client.BigtableConnectionRegistry</value> <!-- When using hbase < 2.3, use this --> <!-- <value>org.apache.hadoop.hbase.client.BigtableAsyncRegistry</value> --> </property> <property> <name>google.bigtable.project.id</name> <value>my-project</value> </property> <property> <name>google.bigtable.instance.id</name> <value>my-instance</value> </property> <property> <name>google.bigtable.app_profile.id</name> <value>my-app-profile</value> </property> </configuration> ``` ```java AsyncConnection asyncConnection = ConnectionFactory.createAsyncConnection().get(); ```
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.12.0](https://togithub.com/googleapis/java-bigtable-hbase/compare/v2.11.3...v2.12.0) (2023-10-18) ### Features * Use concrete classes for hbase.client.registry.impl ([#4043](https://togithub.com/googleapis/java-bigtable-hbase/issues/4043)) ([#4188](https://togithub.com/googleapis/java-bigtable-hbase/issues/4188)) ([cc22f2f](https://togithub.com/googleapis/java-bigtable-hbase/commit/cc22f2f577d32c31417c2cc525eac9649281589f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used runtime bytecode generation which prevented endusers from using hbase-site.xml to target bigtable in hbase 2 applications
Change-Id: I28c28683419ac8f65bccfa770ab7f0e1cc1a4d2f
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.