-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use concrete classes for hbase.client.registry.impl (#4043) #4188
feat: use concrete classes for hbase.client.registry.impl (#4043) #4188
Conversation
…#4043) * feat: use concrete classes for hbase.client.registry.impl Previously we used runtime bytecode generation which prevented endusers from using hbase-site.xml to target bigtable in hbase 2 applications Change-Id: I28c28683419ac8f65bccfa770ab7f0e1cc1a4d2f * address feedback Change-Id: Ia58e2cbcbafa57e08a7f710dd5a5b4d3a4e4bf68 * add missing exclue Change-Id: I452043b55373c1d41024893f5a9781853c9edae7 * wip Change-Id: I03ab0a4283d430de45417807309498a976e32932 * fix bad rebase Change-Id: I9de88c819e110e521bdef638d40c63df36ac605b
Change-Id: If99eab1f51a0749fda495d656193f06d9bf1be01
Change-Id: I58cb63d04697537085aeca41d3614e421a5f96ef
Change-Id: I2996531cb702135d14bfebab056ae335bd126c25
Change-Id: I70e9eab35662dfb2faf15a383a44b65668f6bdd5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any new tests to make sure everything works (e.g., passing the new BigtableConnectionRegistry class or using Async APIs) or they are already covered by the existing tests?
I plan on adding cross version tests, but that will be a much bigger change. I will add them soon |
cc22f2f
into
googleapis:main
🤖 I have created a release *beep* *boop* --- ## [2.12.0](https://togithub.com/googleapis/java-bigtable-hbase/compare/v2.11.3...v2.12.0) (2023-10-18) ### Features * Use concrete classes for hbase.client.registry.impl ([#4043](https://togithub.com/googleapis/java-bigtable-hbase/issues/4043)) ([#4188](https://togithub.com/googleapis/java-bigtable-hbase/issues/4188)) ([cc22f2f](https://togithub.com/googleapis/java-bigtable-hbase/commit/cc22f2f577d32c31417c2cc525eac9649281589f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Previously we used runtime bytecode generation which prevented endusers from using hbase-site.xml to target bigtable in hbase 2 applications. This PR will create a concrete implementation for both AsyncRegistry for (hbase < 2.3) and ConnectionRegistry (for hbase >= 2.3).
To accomplish this, we use a local copy of the AsyncRegistry interface from HBase 2.2 that we use as a compile time target and then strip it from the resulting jar.
After this change end users should be able to use async apis in hbase 2 using hbase-site.xml. Examples: