-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set wait timeout and update default attempt timeout to 30 minutes #1779
Conversation
🤖 I have created a release *beep* *boop* --- ## [2.23.3](https://togithub.com/googleapis/java-bigtable/compare/v2.23.2...v2.23.3) (2023-06-08) ### Bug Fixes * Set wait timeout and update default attempt timeout to 30 minutes ([#1779](https://togithub.com/googleapis/java-bigtable/issues/1779)) ([11019b8](https://togithub.com/googleapis/java-bigtable/commit/11019b87fe32b5b9c9f2d947ffd9191b56120381)) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.20.0 ([#1785](https://togithub.com/googleapis/java-bigtable/issues/1785)) ([8ddd370](https://togithub.com/googleapis/java-bigtable/commit/8ddd370bf747bcc7ad7ccb6f00cc5ef188fa3511)) * Update gapic-generator-java to 2.21.0 ([#1760](https://togithub.com/googleapis/java-bigtable/issues/1760)) ([05545f8](https://togithub.com/googleapis/java-bigtable/commit/05545f87692c05c22d17e431551b4a5f91475286)) * Update shared dependencies to 3.11.0 ([#1783](https://togithub.com/googleapis/java-bigtable/issues/1783)) ([96aaa2a](https://togithub.com/googleapis/java-bigtable/commit/96aaa2a5a5a70feeb8ff0fd20b9dfc4a8a464bb7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
hey @mutianf, sorry to come out of the woodwork, but when my team at work upgraded to use this version of java bigtable, all of our This caused an incident for us as we were unaware that our service was going to start respecting the timeouts. the only upgrade in the java cloud bom diff that seems relevant at all is the java bigtable diff, and this change seems somewhat related, but the retry settings we're seeing reflected don't really have much to do with this change. Do you know any other changes that may have caused our bigtable |
Hi @mcookhome, The relevant change was here: googleapis/sdk-platform-java#1473. I apologize for the disruption |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.