-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: attemp DirectPath by default #467
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,9 +85,6 @@ public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableS | |
private static final int MAX_MESSAGE_SIZE = 256 * 1024 * 1024; | ||
private static final String SERVER_DEFAULT_APP_PROFILE_ID = ""; | ||
|
||
// TODO(weiranf): Remove this temporary endpoint once DirectPath goes to public beta | ||
private static final String DIRECT_PATH_ENDPOINT = "test-bigtable.sandbox.googleapis.com:443"; | ||
|
||
private static final Set<Code> IDEMPOTENT_RETRY_CODES = | ||
ImmutableSet.of(Code.DEADLINE_EXCEEDED, Code.UNAVAILABLE); | ||
|
||
|
@@ -166,12 +163,6 @@ public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableS | |
private EnhancedBigtableStubSettings(Builder builder) { | ||
super(builder); | ||
|
||
if (DIRECT_PATH_ENDPOINT.equals(builder.getEndpoint())) { | ||
logger.warning( | ||
"Connecting to Bigtable using DirectPath." | ||
+ " This is currently an experimental feature and should not be used in production."); | ||
} | ||
|
||
// Since point reads, streaming reads, bulk reads share the same base callable that converts | ||
// grpc errors into ApiExceptions, they must have the same retry codes. | ||
Preconditions.checkState( | ||
|
@@ -245,13 +236,7 @@ public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProvi | |
.setKeepAliveTimeout( | ||
Duration.ofSeconds(10)) // wait this long before considering the connection dead | ||
.setKeepAliveWithoutCalls(true) // sends ping without active streams | ||
// TODO(weiranf): Set this to true by default once DirectPath goes to public beta | ||
.setAttemptDirectPath(isDirectPathEnabled()); | ||
} | ||
|
||
// TODO(weiranf): Remove this once DirectPath goes to public beta | ||
private static boolean isDirectPathEnabled() { | ||
return Boolean.getBoolean("bigtable.attempt-directpath"); | ||
.setAttemptDirectPath(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment on why we attemt DirectPath? to give context to future readers. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added comment. PTAL at the wording, thanks! |
||
} | ||
|
||
static int getDefaultChannelPoolSize() { | ||
|
@@ -526,13 +511,7 @@ private Builder() { | |
// Defaults provider | ||
BigtableStubSettings.Builder baseDefaults = BigtableStubSettings.newBuilder(); | ||
|
||
// TODO(weiranf): remove this once DirectPath goes to public Beta and uses the default | ||
// endpoint. | ||
if (isDirectPathEnabled()) { | ||
setEndpoint(DIRECT_PATH_ENDPOINT); | ||
} else { | ||
setEndpoint(baseDefaults.getEndpoint()); | ||
} | ||
setEndpoint(baseDefaults.getEndpoint()); | ||
|
||
setTransportChannelProvider(defaultTransportChannelProvider()); | ||
setStreamWatchdogCheckInterval(baseDefaults.getStreamWatchdogCheckInterval()); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anywhere we can keep this logging information to confirm (in tests, for example) that we are connecting using DirectPath?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For tests we inject hooks into netty to ensure that directpath is used, also the integration tests generate verbose grpc logs which would show directpath usage. For prod usage, we dont really have a good way to introspect it as its a grpc level feature