Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add batch throttled ms metric #888

Merged
merged 9 commits into from Dec 10, 2021
Merged

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jun 23, 2021

BatcherImpl will add throttled time to ApiCallContext. Get the time from call context and export it to batch_throttled_time metric.

(This change depends on new gax release with googleapis/gax-java#1463)

@product-auto-label product-auto-label bot added the api: bigtable label Jun 23, 2021
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@mutianf mutianf changed the title feat: add batch metrics feat: add batch throttled ms metric Oct 29, 2021
@mutianf mutianf marked this pull request as ready for review Oct 29, 2021
@mutianf mutianf requested a review from as a code owner Oct 29, 2021
@mutianf mutianf requested a review from igorbernstein2 Nov 22, 2021
@mutianf mutianf added the kokoro:force-run label Dec 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Dec 3, 2021
metricsTracerMethodNames.add(method.getName());
}
for (Method method : baseMethods) {
Truth.assertThat(metricsTracerMethodNames).contains(method.getName());
Copy link
Contributor

@igorbernstein2 igorbernstein2 Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as CompositeTracer

@mutianf mutianf merged commit 0d197a5 into googleapis:main Dec 10, 2021
17 checks passed
@mutianf mutianf deleted the throttle_stats2 branch Dec 10, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 5, 2022
mutianf pushed a commit to mutianf/java-bigtable that referenced this issue Mar 18, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [2.5.0](https://www.github.com/googleapis/java-bigtable/compare/v2.4.0...v2.5.0) (2022-01-05)


### Features

* add batch throttled ms metric ([googleapis#888](https://www.github.com/googleapis/java-bigtable/issues/888)) ([0d197a5](https://www.github.com/googleapis/java-bigtable/commit/0d197a5ab9b7ccd20091c1c6c4a794586d6a51dc))
* ARM support for gcloud bigtable emulator ([googleapis#1094](https://www.github.com/googleapis/java-bigtable/issues/1094)) ([d3cb4a4](https://www.github.com/googleapis/java-bigtable/commit/d3cb4a4e03ae0f7e065bfee06ac8e3b86b447a4a))


### Bug Fixes

* align ip version preference for the wrapped  emulator ([googleapis#1052](https://www.github.com/googleapis/java-bigtable/issues/1052)) ([9dc93c5](https://www.github.com/googleapis/java-bigtable/commit/9dc93c5c9372f1501006e2d3a3a7affecd65fb8e))
* remove stats from javadoc ([googleapis#1108](https://www.github.com/googleapis/java-bigtable/issues/1108)) ([33fe7fe](https://www.github.com/googleapis/java-bigtable/commit/33fe7fe162cf84339e1887b052e446ef0aaf19d6))
* remove tracking latency from channel priming requests ([googleapis#1082](https://www.github.com/googleapis/java-bigtable/issues/1082)) ([bd873bc](https://www.github.com/googleapis/java-bigtable/commit/bd873bc82f0b210312fd442678c801758291935e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants