Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client.close() should wait until the channels are terminated before shutting down the executor #916

Merged
merged 2 commits into from Jul 19, 2021

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Jul 16, 2021

Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor

…ore shutting down the executor

Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor
@igorbernstein2 igorbernstein2 requested a review from mutianf Jul 16, 2021
@igorbernstein2 igorbernstein2 requested a review from as a code owner Jul 16, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Jul 16, 2021
@google-cla google-cla bot added the cla: yes label Jul 16, 2021
@igorbernstein2 igorbernstein2 merged commit 914f0cc into googleapis:master Jul 19, 2021
17 checks passed
@igorbernstein2 igorbernstein2 deleted the fix-close branch Jul 19, 2021
kolea2 pushed a commit to kolea2/java-bigtable that referenced this issue Sep 9, 2021
…ore shutting down the executor (googleapis#916)

* fix: client.close() should wait until the channels are terminated before shutting down the executor

Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor

* copyright

(cherry picked from commit 914f0cc)
kolea2 added a commit that referenced this issue Sep 10, 2021
…ore shutting down the executor (#916) (#1000)

* fix: client.close() should wait until the channels are terminated before shutting down the executor

Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor

* copyright

(cherry picked from commit 914f0cc)

Co-authored-by: Igor Bernstein <igorbernstein@google.com>
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants