Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FILTERS.timestamp().exact() for better access & read ability. #92

Merged
merged 1 commit into from Nov 18, 2019

Conversation

rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Nov 18, 2019

Fixes #65

@googlebot googlebot added the cla: yes label Nov 18, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 18, 2019

Codecov Report

Merging #92 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     81.33%   81.33%   +<.01%     
  Complexity      937      937              
============================================
  Files            95       95              
  Lines          5849     5850       +1     
  Branches        325      325              
============================================
+ Hits           4757     4758       +1     
  Misses          916      916              
  Partials        176      176
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigtable/data/v2/models/Filters.java 75% <100%> (+0.14%) 16 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1834fc1...ae96870. Read the comment docs.

…lity

This change introduces `FILTERS.timestamp().exact()`, which enable user to directly provide exact timestamp to query Bigtable.
.setTimestampRangeFilter(
TimestampRange.newBuilder()
.setStartTimestampMicros(20_000L)
.setEndTimestampMicros(20_000L + 1))
Copy link
Collaborator

@kolea2 kolea2 Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why + 1 here?

Copy link
Contributor Author

@rahulKQL rahulKQL Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimestampRange#endTimestampMicros denotes upper bound for timestamp range. If we pass the same value then no rows will return.

Copy link
Contributor

@igorbernstein2 igorbernstein2 Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end range cap is exclusive, so for a single number, the range is [x, x+1)

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Lgtm

@igorbernstein2 igorbernstein2 merged commit e25758b into googleapis:master Nov 18, 2019
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants